Validate Routes in Test Cases throwing an error if route is not specified when required#490
Open
Validate Routes in Test Cases throwing an error if route is not specified when required#490
Conversation
83e55f6 to
a3d030b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate Routes in Test Cases
Discovered in https://github.com/getyourguide/routes/pull/3029 , see (https://github.com/getyourguide/routes/pull/3029#discussion_r2704499904)
This pull request introduces validation to ensure that when simple routing is requested (with wantMatch set to false), a route must be provided in the test cases. Without a defined route, the parser now returns an explicit error.
Changes include:
ErrRouteRequiredForSimpleRoutingto signal missing required routes.This improves the robustness of configuration validation by enforcing necessary route definitions in test cases.