Fix modulePath in a nested module#15
Closed
DevSrSouza wants to merge 1 commit intogetyourguide:mainfrom
Closed
Conversation
Member
|
Closing stale PR. If this is a mistake, please re-open. |
Member
|
@arecmetafora sorry about this. Let me find the right owner for #30 to be reviewed. |
@alexef I pushed some changes to address this and the plugin compatibility. It was already reviewed and approved, so I guess we can use that one instead of reopening this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on nested module setup
modules.asSequence().map { it.getModuleDir() }.firstOrNull { file.path.startsWith(it) }was never called and it was always fallbacking tobasePath?.let { projectPath -> ...But it does not support nested module setup, this should fix it. All test files usually are located inside thesrcfolder and the src folder is the child folder of a module.