Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds python3.8 support with AnnAssign and NamedExpr #52

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Adds python3.8 support with AnnAssign and NamedExpr #52

merged 1 commit into from
Mar 14, 2020

Conversation

sobolevn
Copy link
Contributor

Closes #50
Closes #49

@sobolevn
Copy link
Contributor Author

@gforcada why is CI disabled? I cannot find my build 😢

@gforcada
Copy link
Owner

@sobolevn no idea, I did not disable them on purpose, I will try to see what's going on

@gforcada
Copy link
Owner

No idea why it is not reported here, but the travis build is here: https://travis-ci.org/github/gforcada/flake8-builtins/builds/661968564 seems that we have a problem with cffi on python 3.8 😕

@sobolevn
Copy link
Contributor Author

@gforcada why do we need cffi?

@gforcada
Copy link
Owner

No idea, I'm fixing it on #53 🤞

@gforcada gforcada merged commit 0448295 into gforcada:master Mar 14, 2020
@sobolevn sobolevn deleted the python38 branch March 14, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Walrus operator is not supported Names that use AnnAssign are not supported
2 participants