Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the device OpenGL context for WGL surfaces #4271

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Oct 20, 2023

This uses a single OpenGL context per device instead of creating an OpenGL context per surface and sharing it using wglShareLists. This is allowed by setting up the pixel format on the surfaces before trying to use the OpenGL context. This is cleaner and makes presentation work on Intel Sandy Bridge.

Tested on i5-1035G1, i5-6200U and HD 5870.

@Zoxc Zoxc requested a review from a team as a code owner October 20, 2023 17:06
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this also works with multiple windows and on my 1080ti!

@cwfitzgerald cwfitzgerald merged commit e918031 into gfx-rs:trunk Oct 20, 2023
23 checks passed
@Zoxc Zoxc deleted the wgl-single branch October 20, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants