Skip to content

Rework of wgpu_hal vulkan buffer importing #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

SupaMaggie70Incorporated
Copy link
Contributor

Connections
Discussed briefly with @cwfitzgerald in matrix chat.

Description

  • Moved wgpu_hal's vulkan buffer constructor to the buffer type
  • Added from_raw_managed, so that the buffer's memory can be managed by wgpu rather than externally

Testing
Currently no testing. I don't believe there is any testing for the existing work either however.

Squash or Rebase?

Either works, there is only one commit at the moment.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant