Skip to content

Allow enabling additional vulkan extensions in Adapter::open and Instance::init #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Vecvec
Copy link
Collaborator

@Vecvec Vecvec commented Jun 19, 2025

Connections
Updated version of #7334
Fixes #7324 (including additional bit requested by @JMS55)

Description
Adds Adapter::open_with_callback & Instance::init_with_callback which have a callback that can add extensions to the device/instance respectively. Moves Adapter::open & Instance::init to be defined in terms of these functions so that they do not fall out of sync.

Testing
Like other hal functions it is untested.

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec requested a review from a team as a code owner June 19, 2025 01:19
@Vecvec Vecvec force-pushed the create-device-hal-callback-new branch from a4a836d to 174379f Compare June 19, 2025 01:20
@JMS55
Copy link
Collaborator

JMS55 commented Jun 19, 2025

I don't have time today, but before this is merged I would like to validate that it will work with https://github.com/JMS55/dlss_wgpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable arbitrary Vulkan extensions in a wgpu-compatible way
2 participants