Skip to content

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Sep 17, 2025

Connections

Testing

  • Yes.

Squash or Rebase?

squashplz

Checklist

  • If this contains user-facing changes, add a CHANGELOG.md entry.

@ErichDonGubler
Copy link
Member Author

Not sure if we needs tests or a CHANGELOG yet. Thoughts, @gfx-rs/wgpu?

@andyleiserson
Copy link
Contributor

I created some infrastructure for testing extension availability, but it's for the case where the extension is supported.

I do think it's worth adding a test, mostly to document the state of affairs. Nothing fancy, just a wgsl_errors test for the error that gets raised when enable primitive-index appears in WGSL.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-triangular-lemon branch from d460f3b to b6f1828 Compare September 18, 2025 14:54
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-triangular-lemon branch 2 times, most recently from 495a01f to 4e3157a Compare September 30, 2025 21:35
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-boinging-triangular-lemon branch from 4e3157a to 7b16345 Compare September 30, 2025 21:36
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Sep 30, 2025

Welp, it was definitely worth making those tests, because I'd incorrectly written primitive-index as the WGSL enable-extension identifier, but that's not even an identifier. +1 for testing!

I had to add UnimplementedEnableExtension to the public API (and I CHANGELOG'd it), but we already do this with UnimplementedLanguageExtension, so I think it's fine.

@ErichDonGubler ErichDonGubler added naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language type: enhancement New feature or request labels Sep 30, 2025
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) September 30, 2025 21:40
@ErichDonGubler ErichDonGubler merged commit 06fc6f7 into gfx-rs:trunk Sep 30, 2025
41 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler-push-boinging-triangular-lemon branch September 30, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants