-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix building & UTF8 output with MSVC + SDL2 #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
#2804 is 99.99% just SDL2.dll not being with the binaries. So I'm a little confused by this PR's naming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI errors are unrelated to this change. If the errors persist, we can apply the same fix that we did in llama.cpp: ggml-org/llama.cpp#11895
Thanks, this fixes the whisper-stream build for me on Win10 with MSVC, but the app is exiting immediately after launch with no indication of why:
|
@tokyovigilante You need to copy SDL2.dll to |
Thanks for looking, I think this should be ok?
[EDIT] |
This PR could also solve the issue mentioned in #2804, in which, TDM64 (gcc compiler) is used because MSVC failed to build.
Note: example
lsp
talks to vim script through std IO, so not updated.