feat(server): enhance server concurrency with task queue, worker threads, and graceful shutdown #3181
+992
−549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaarbonel
changed the title
danbev
reviewed
May 23, 2025
|
|
||
| // RAII guard for HTTP request counting | ||
| struct HttpRequestCounter { | ||
| explicit HttpRequestCounter(std::atomic<int>& counter) : ctr(counter) { ctr.fetch_add(1, std::memory_order_relaxed); } |
There was a problem hiding this comment.
Nit: could you put the constructor implementation on a new line here:
explicit HttpRequestCounter(std::atomic<int> & counter) : ctr(counter) {
ctr.fetch_add(1, std::memory_order_relaxed);
}
And also prefer the reference to not lean to the left. | // RAII guard for HTTP request counting | ||
| struct HttpRequestCounter { | ||
| explicit HttpRequestCounter(std::atomic<int>& counter) : ctr(counter) { ctr.fetch_add(1, std::memory_order_relaxed); } | ||
| ~HttpRequestCounter() { ctr.fetch_sub(1, std::memory_order_relaxed); } |
There was a problem hiding this comment.
Nit: same as above perhaps put the destructor body on a new line.
| fprintf(stderr, " --keep-alive-timeout N, [%-7d] Idle keep-alive timeout in seconds\n", sparams.keep_alive_timeout); | ||
| fprintf(stderr, " --backlog N, [%-7d] Listen() backlog (max pending connections)\n", sparams.listen_backlog); | ||
| fprintf(stderr, " --max-upload-size N, [%-7zu] Max upload size in bytes (default 104857600)\n", sparams.max_upload_size); | ||
| fprintf(stderr, " --temp-upload-dir DIR, [%-7s] Directory for temporary uploads\n", sparams.temp_upload_dir.c_str()); |
There was a problem hiding this comment.
Nit: perhaps line up indentation.
| case ErrorType::INVALID_REQUEST: return "invalid_request_error"; | ||
| case ErrorType::SERVER_ERROR: return "server_error"; | ||
| case ErrorType::NOT_FOUND: return "not_found_error"; | ||
| default: return "unknown_error"; |
There was a problem hiding this comment.
Nit: perhaps line up the indentation here.
| case ErrorType::INVALID_REQUEST: return 400; | ||
| case ErrorType::SERVER_ERROR: return 500; | ||
| case ErrorType::NOT_FOUND: return 404; | ||
| default: return 500; |
There was a problem hiding this comment.
Nit: perhaps line up the indentation here.
| ThreadGuard(const ThreadGuard&) = delete; | ||
| ThreadGuard& operator=(const ThreadGuard&) = delete; | ||
| ThreadGuard(ThreadGuard&& other) noexcept : t(std::move(other.t)) {} | ||
| ThreadGuard& operator=(ThreadGuard&& other) noexcept { if (t.joinable()) t.join(); t = std::move(other.t); return *this; } |
There was a problem hiding this comment.
Nit: implementation of function could be on a separate/new lines for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements in this update focus on making the server more robust, efficient, and easier to manage:
These changes collectively make the server more resilient under load, easier to tune for different environments, and safer to operate in production.