Resolve Compile Warning and raise Elixir Minimum Requirement to 1.10#71
Open
maennchen wants to merge 2 commits intoggpasqualino:mainfrom
Open
Resolve Compile Warning and raise Elixir Minimum Requirement to 1.10#71maennchen wants to merge 2 commits intoggpasqualino:mainfrom
maennchen wants to merge 2 commits intoggpasqualino:mainfrom
Conversation
maennchen
force-pushed
the
elixir_compile_warning
branch
from
ed5d95f to
9c61387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following compile warning:
Since the function
Code.ensure_compiled/1is only available since Elixir 1.10, I raised the minimum requirement.If you prefer, we could also detect the Elixir Version and leave the old code in place for older versions.
Based on #72, merge that first.