-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for NCCL in communication_object
#195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
msimberg
wants to merge
55
commits into
ghex-org:master
Choose a base branch
from
msimberg:nccl-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 47 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
99fe0a0
Try 1d block for pack/unpack
msimberg 527d590
Add dumb nccl implementation
msimberg 78879bb
Add back cuda event class
msimberg f314a1c
Add TODO for nccl in cmake
msimberg ab0dfd0
Clean up nccl parts
msimberg 4b5833f
Small fix to stream syncing with nccl
msimberg ee1b851
Update test to disable cpu exchange with nccl
msimberg 186965d
Merge branch 'async-mpi-2' into nccl-2
msimberg 2744fec
Add FindNCCL.cmake
msimberg 618e7eb
Update communication object for nccl integration
msimberg b7f573d
Update oomph
msimberg aede6ab
Update oomph
msimberg 38cb29b
Update oomph
msimberg bacc1a4
Remove debug print
msimberg fe958f2
Minor cleanup
msimberg 0fc74be
Merge commit 'f7273c2a232a0bb37cf869c9ee33c688387cf41b' into nccl-2
msimberg 49b9bf7
Format files
msimberg 34fc8d0
Update oomph
msimberg a51de83
Merge remote-tracking branch 'philip-paul-mueller/phimuell__async-mpi…
msimberg 0614d9b
Update oomph
msimberg dd3257b
Merge remote-tracking branch 'origin/master' into nccl-2
msimberg 83a1c7e
Remove NCCL macros
msimberg f112e4f
Sync with master
msimberg 15e7c05
Update oomph
msimberg 0d91ac9
Merge remote-tracking branch 'philip-paul-mueller/phimuell__async-mpi…
msimberg b9f4d55
Make cmake configuration error out if GPU support isn't enabled when …
msimberg 26f4f3e
Remove unused functions in packer
msimberg baf0dc6
Remove dummy callback todos
msimberg 3f7709f
Small updates
msimberg d1b41ea
Small fixes to async mode
msimberg 173abd7
Clean up communication object exchange implementations
msimberg d8c8631
Refactor packing/unpacking etc.
msimberg 9e695c3
More pack/unpack cleanup
msimberg 6367449
Format files
msimberg 606e4d0
Un-disable a test with NCCL
msimberg ac9f1c1
Minor cleanup
msimberg 4a491fd
Update oomph
msimberg ffbb066
Update oomph
msimberg 5dee034
Minor formatting, unused variable warnings etc.
msimberg da0f77c
Fix compilation with hip
msimberg 289a761
Formatting
msimberg fdcd4ac
Formatting
msimberg 4aaaadf
Merge remote-tracking branch 'philip-paul-mueller/phimuell__async-mpi…
msimberg 993393d
Remove wrong assertion
msimberg 7459c63
Update some tests for NCCL
msimberg 5a65526
Disable more tests with NCCL
msimberg e6cec86
Merge tag 'v0.5.0' into nccl-2
msimberg c28a432
Add comment about NCCL PXN to cubed_sphere tests
msimberg 21bb1c0
Fix compilation
msimberg f5bbf49
Update oomph
msimberg 451c51d
Remove unnecessary find_package(NCCL)
msimberg 2719c94
Add back comment
msimberg 5f6e151
Rethrow exceptions with bare throw
msimberg 793c766
Remove outdated comment
msimberg ec275a8
Use high priority CUDA streams
msimberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gridtools
updated
5 files
| +12 −12 | README.md | |
| +1 −1 | docs_src/manuals/getting_started/code/CMakeLists.txt | |
| +0 −76 | include/gridtools/common/demangle.hpp | |
| +2 −2 | include/gridtools/stencil/dump.hpp | |
| +1 −1 | version.txt |
Submodule oomph
updated
42 files
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do: is this needed in ghex or enough in oomph?