Skip to content

WIP: nanobind and Type Stubs #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philip-paul-mueller wants to merge 39 commits into
base: master
Choose a base branch
from
Open

WIP: nanobind and Type Stubs #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
51735b3
Initial nanobind refactoring
msimberg Mar 6, 2026
fb8c554
Some fixes
msimberg Mar 17, 2026
07f2809
More fixes
msimberg Mar 18, 2026
a6ab6b4
Only look for Python in cmake, not both Python and Python3
msimberg Mar 18, 2026
f883830
Remove Python.h include
msimberg Mar 18, 2026
1a9fc3b
Remove pybind-version from config
msimberg Mar 18, 2026
d08d73c
Minor cleanup
msimberg Mar 18, 2026
3b463ba
Remove unused include
msimberg Mar 18, 2026
5303826
Bugfixes
msimberg Mar 18, 2026
2194626
Add nanobind-dev to ci
msimberg Mar 18, 2026
5467063
Remove test
msimberg Mar 19, 2026
8f08f9d
Require consistent cmake versions
msimberg Mar 19, 2026
2ee5174
Clean up pyproject build-system requires
msimberg Mar 19, 2026
dfeb576
Revert some overeager changes
msimberg Mar 19, 2026
439c70f
Fix typo in pyproject.toml
msimberg Mar 19, 2026
74f1fe9
Support nanobind 1.x
msimberg Mar 19, 2026
1d8945a
Try to fix cuda build with nanobind
msimberg Mar 19, 2026
677862a
If `nanobind` is installed on the system it might not be found.
philip-paul-mueller Apr 8, 2026
be58b34
First version that does nto fully work yet.
philip-paul-mueller Apr 9, 2026
e5bcca9
Fixed an import issue.
philip-paul-mueller Apr 9, 2026
00088e6
Now the names are a bit different and the `pyghex` vs. `_pyghex` no l…
philip-paul-mueller Apr 9, 2026
2fc822d
Now the file is transported as it should.
philip-paul-mueller Apr 9, 2026
075590f
Relocated this file.
philip-paul-mueller Apr 9, 2026
f9e5150
Some modification in the path.
philip-paul-mueller Apr 9, 2026
c2c98f6
Now there is a proper dependency.
philip-paul-mueller Apr 9, 2026
f08e7a9
Not sure if this does the trick.
philip-paul-mueller Apr 9, 2026
8ccd52f
Okay it is not that, because the CI once passed, but I do not underst…
philip-paul-mueller Apr 9, 2026
54015fb
Now the `REQUIRE` argument of the `find_python_module()` is respected.
philip-paul-mueller Apr 9, 2026
00d504c
Fixed the CI.
philip-paul-mueller Apr 9, 2026
38c4df1
Only run `nanobind_add_stub()` if it is present also print version.
philip-paul-mueller Apr 9, 2026
e196a86
Fixed the dependecy.
philip-paul-mueller Apr 9, 2026
a1194e3
The Python package now needs a higher nanobind version.
philip-paul-mueller Apr 9, 2026
7a6003d
Will solve that problem later.
philip-paul-mueller Apr 10, 2026
e1c33ce
New way of finding `nanobind`.
philip-paul-mueller Apr 10, 2026
14cd346
Merge remote-tracking branch 'ghex/master' into nanobind_philip
philip-paul-mueller Apr 10, 2026
e71a4d1
Let's do some debugging.
philip-paul-mueller Apr 10, 2026
7b98619
It seems that sometimes the `nanobind` version can not be determined.
philip-paul-mueller Apr 10, 2026
6e95565
Let's hope that Mikael is right.
philip-paul-mueller Apr 10, 2026
4f52bcf
Fixed this merge.
philip-paul-mueller Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ jobs:
- name: Install packages
run: |
apt update
apt-get -y install python3-dev python3-venv python3-pybind11 ninja-build
# TODO: Use `python3-nanobind` instead of `nanobind-dev` once it is in the repo.
apt-get -y install python3-dev python3-venv nanobind-dev ninja-build

- name: Clone w/ submodules
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_pip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Install python
run: |
apt update
apt-get -y install python3-dev python3-venv python3-pybind11
apt-get -y install python3-dev python3-venv

- name: Clone w/ submodules
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Documentation and instructions at [GHEX Documentation](https://ghex-org.github.i
- gfortran compiler (optional, for Fortran bindings)
- Python3 (optional, for Python bindings )
- MPI4PY (optional, for Python bindings )
- Pybind11 (optional, for Python bindings)
- Nanobind (optional, for Python bindings)

### From Source

Expand Down
2 changes: 1 addition & 1 deletion bindings/python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
add_subdirectory(src/_pyghex)
add_subdirectory(src/pyghex)
add_subdirectory(src/ghex)
53 changes: 0 additions & 53 deletions bindings/python/src/_pyghex/py_dtype_to_cpp_name.cpp
View file
Open in desktop

This file was deleted.

180 changes: 0 additions & 180 deletions bindings/python/src/_pyghex/structured/regular/field_descriptor.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading