refactor: replace fastStartsWith & fastStartsWithFrom
#4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SukkaW , Thanks for the contribution. We're measuring the actual speed difference in multiple platforms to be sure. Once we're ready, we'll merge it. Best |
seia-soto
approved these changes
Jan 22, 2025
remusao
approved these changes
Jan 22, 2025
|
It took a while to make some benchmarks but we are now sure the changes are beneficial. Thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4517.
Per benchmarks mentioned in the issue,
fastStartsWith&fastStartsWithFromare consistently slower on modern Chrome and modern Firefox (up to 0.5x to 1x slower).All tests and lints passed locally on my machine.