Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gamsesight.eno #644

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

BrianClifton
Copy link
Contributor

@seia-soto
Copy link
Member

Hi @BrianClifton , can we merge this with #643 ?

@BrianClifton
Copy link
Contributor Author

Hmmm - this confused me... #643 is the org file, #644 is the pattern file

@seia-soto
Copy link
Member

@BrianClifton Sorry for the late reply. I meant how about creating both organization file and pattern file in a single PR. From my knowledge, pattern file always depend on the organization file by the organization field. With this change, the relationship between files could be clarified and it will also make the test pass.

@BrianClifton
Copy link
Contributor Author

BrianClifton commented Jan 14, 2025 via email

@philipp-classen philipp-classen merged commit 8c47930 into ghostery:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants