Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add context menu key #5162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

core: add context menu key #5162

wants to merge 1 commit into from
+4 −0

Conversation

jcollie
Copy link
Collaborator

@jcollie jcollie commented Jan 16, 2025

I have this key on a cheap Lenovo keyboard at work and would like to put it to some use.

mitchellh
mitchellh requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe that any changes to the Key enum require changes to libghostty's header and possibly some Swift. I can check the Swift but definitely check the header please.

src/input/key.zig Outdated Show resolved Hide resolved
@jcollie jcollie force-pushed the core-context-menu-key branch from cde4043 to 39630bf Compare January 21, 2025 00:17
@jcollie
Copy link
Collaborator Author

jcollie commented Jan 21, 2025

I also believe that any changes to the Key enum require changes to libghostty's header and possibly some Swift. I can check the Swift but definitely check the header please.

I didn't touch the swift code, as I'm not exactly sure what the values in Ghostty.Input.swift are supposed to correspond to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellh mitchellh mitchellh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcollie @mitchellh