Skip to content

d3d11: use sync.Pool for Buffers to avoid garbage #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

d3d11: use sync.Pool for Buffers to avoid garbage #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gpu/internal/d3d11/d3d11_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"image"
"math"
"math/bits"
"sync"
"unsafe"

"golang.org/x/sys/windows"
Expand Down Expand Up @@ -89,6 +90,8 @@ type Buffer struct {
immutable bool
}

var bufferPool sync.Pool = sync.Pool{New: func() any { return &Buffer{} }}

func init() {
driver.NewDirect3D11Device = newDirect3D11Device
}
Expand Down Expand Up @@ -472,7 +475,9 @@ func (b *Backend) newBuffer(typ driver.BufferBinding, size int, data []byte, imm
return nil, err
}
}
return &Buffer{backend: b, buf: buf, bind: bind, size: size, resView: resView, uaView: uaView, immutable: immutable}, nil
buffer := bufferPool.Get().(*Buffer)
*buffer = Buffer{backend: b, buf: buf, bind: bind, size: size, resView: resView, uaView: uaView, immutable: immutable}
return buffer, nil
}

func (b *Backend) NewComputeProgram(shader shader.Sources) (driver.Program, error) {
Expand Down Expand Up @@ -750,6 +755,7 @@ func (b *Buffer) Release() {
}
d3d11.IUnknownRelease(unsafe.Pointer(b.buf), b.buf.Vtbl.Release)
*b = Buffer{}
bufferPool.Put(b) // Return to pool for reuse. Note: this means that you should not use the buffer after calling Release.
}

func (t *Texture) ReadPixels(src image.Rectangle, pixels []byte, stride int) error {
Expand Down