app, cmd/gogio: add android foreground permission and service #67
Conversation
|
I've tested this with my application; but feel that there could be better integration with the notification library gioui.org/x/notify, so that the foreground service can share the same notification channels, in particular so that the text of the background notification can be updated. I'm not sure that this change should depend on that package though, but I think that the Service class needs to be declared in the application manifest. Any help resolving/improving the above details is very much appreciated. |
|
Nice work, thank you.
Why share notifications with niotify? This change is for foreground work, niotify is for notifications. However, see my review comments for a suggestion to customize foreground notification content text. |
|
Oh, and remember to sign-off your change and squash commits. |
well, the foreground service requires a notification - the code here just sets a static string which isn't very appealing. Android applications using foreground services tend to have some kind of content displayed in the service notification and it would be useful to have a clean way to interact with the notification - possibly the StartForeground method should return or accept this as an argument - and this is where it starts to overlap with the functionality provided by niotify. |
|
edit: fixed |
mixmasala
force-pushed
the
add_foreground_service
branch
from
596a0f2 to
87a7c2f
Compare
|
I've refactored this PR to address issues raised above and changed the API to include setting the notification ID, title, and text. |
mixmasala
force-pushed
the
add_foreground_service
branch
from
87a7c2f to
d295b22
Compare
mixmasala
force-pushed
the
add_foreground_service
branch
4 times, most recently
from
c65a7be to
917b1da
Compare
|
edit: stopped using startForegroundService because I saw some crash with resuming the application from background with same error as: transistorsoft/nativescript-background-geolocation-lt#121 (comment) . Instead startService is used, which fixes this crash. |
mixmasala
force-pushed
the
add_foreground_service
branch
6 times, most recently
from
206d76d to
37f30b7
Compare
mixmasala
force-pushed
the
add_foreground_service
branch
2 times, most recently
from
f0f3c2a to
84b41ef
Compare
mixmasala
force-pushed
the
add_foreground_service
branch
from
84b41ef to
44a59e2
Compare
mixmasala
force-pushed
the
add_foreground_service
branch
2 times, most recently
from
5a91e41 to
a1625b7
Compare
whereswaldon
force-pushed
the
main
branch
4 times, most recently
from
0d543a0 to
1686874
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
67c77c9 to
46cc311
Compare
whereswaldon
force-pushed
the
main
branch
2 times, most recently
from
f8029f2 to
026d3f9
Compare
whereswaldon
force-pushed
the
main
branch
13 times, most recently
from
3d36537 to
74ccc9c
Compare
mixmasala
force-pushed
the
add_foreground_service
branch
from
a1625b7 to
a19029d
Compare
This adds the permission android.permission.FOREGROUND_SERVICE and adds GioForegroundService which creates the tray Notification necessary to implement the Foreground Service. This adds the method Start to package app, which on android, notifies the system that the program will perform background work and that it shouldn't be killed. The foreground service is stopped using the cancel function returned by Start(). If multiple calls to Start are made, the foreground service will not be stopped until the final cancel function has been called. See https://developer.android.com/guide/components/foreground-services and https://developer.android.com/training/notify-user/build-notification Signed-off-by: Masala <[email protected]>
mixmasala
force-pushed
the
add_foreground_service
branch
from
a19029d to
20227d2
Compare
|
Is there any progress on this? Write Android applications in pure Go by adding services and BroadcastReceiver support. |
3 participants
This adds the permission android.permission.FOREGROUND_SERVICE and adds
GioForegroundService which creates the tray Notification necessary to
implement the Foreground Service. The package foreground includes the method
StartForeground, which on android, notifies the system that the program
will perform background work and that it shouldn't be killed. It returns
a channel that should be closed when the background work is complete.
See https://developer.android.com/guide/components/foreground-services
and https://developer.android.com/training/notify-user/build-notification