Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden divs for frame_id and frame_styling #1136

Merged
merged 3 commits into from
May 1, 2023
Merged

Add hidden divs for frame_id and frame_styling #1136

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a691863
Add hidden divs for frame_id and frame_styling
annehaley Apr 28, 2023
73f8ec2
Update FrameSelector.vue
annehaley May 1, 2023
1a4fc2e
Update FrameSelector.vue
annehaley May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions girder/girder_large_image/web_client/vue/components/FrameSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default Vue.extend({
currentModeId: 1,
indices: [],
indexInfo: {},
style: {},
};
},
watch: {
Expand Down Expand Up @@ -50,6 +51,7 @@ export default Vue.extend({
frame += info.current * info.stride;
}
});
this.currentFrame = frame
let style = this.currentModeId > 1 ? this.style : undefined
this.frameUpdate(frame, style);
},
Expand Down Expand Up @@ -135,6 +137,8 @@ export default Vue.extend({

<template>
<div class="image-frame-control-box">
<div id="frame_id" style="display: none;">{{ currentFrame }}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to propose different element IDs for these: current_image_frame and current_image_style.

<div id="frame_styling" style="display: none;">{{ style }}</div>
<div>
<label for="mode">Image control mode: </label>
<select
Expand Down