Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram AutoRange True Values #1803

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Histogram AutoRange True Values #1803

merged 6 commits into from
Feb 5, 2025

Conversation

annehaley
Copy link
Collaborator

When using the Histogram Editor within the Frame Selector component, this PR keeps the min and max input boxes visible even when autoRange is enabled (though they are disabled in that case). The min and max inputs show the real values when specifying range with a distribution percentage.

Resolves #1030.

image

@annehaley annehaley requested a review from manthey February 3, 2025 16:04
@manthey
Copy link
Member

manthey commented Feb 3, 2025

I like this a lot, but in the HistomicsUI instance of this we don't have space to show these boxes (since the right side of the area we do have gets used up by the auto-range percent. We can hide these in that instance, but it'd cool if we can also add tooltips maybe to the grey areas of the histogram (or the drag handles) that would also show these values?

@annehaley annehaley force-pushed the hist-autorange-vals branch from 5432cae to 36645bb Compare February 3, 2025 22:44
@manthey
Copy link
Member

manthey commented Feb 4, 2025

I think you need "user-select" none on the tooltip bubbles.

@annehaley annehaley merged commit 783179c into master Feb 5, 2025
18 checks passed
@annehaley annehaley deleted the hist-autorange-vals branch February 5, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method or endpoint to get histogram max/min:<value> direct values
2 participants