Fixed ambiguous assemble() overrides #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change CI (hopefully runs only gsElasticity examples)
fix paraview fix mass assembler error
This reverts commit f9f73b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assemble()’ function with default parameter leads to a compiler error with AppleClang about ambiguous functions since it is not clear if the empty-parameter variant of ‘assemble()’ from the base class should be used or the override from the deriving class with default parameter ‘false’. This commit fixes this ambiguity.
EDIT from @hverhelst: This commit also fixes loads of warnings coming from compilation with
GISMO_WITH_WARNINGS=ON. In addition, the CI is fixed