Hot fix lookup - #21
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors gsLookupFunction to use unique_ptr for Piece_t storage, updates cloning to handle pointer semantics, and changes gsLookupFunctionSingle to hold references for points and data.
- Switched
Containertostd::vector<memory::unique_ptr<Piece_t>> - Implemented deep-copy
clone()viaclone_impl() - Updated
add(),set(), and evaluation methods to work with pointers - Changed
m_pointsandm_dataingsLookupFunctionSingleto references
Comments suppressed due to low confidence (2)
gsLookupFunction.h:158
- [nitpick] The comment references
shared_ptreven though it isn’t used elsewhere. Clarify whyunique_ptris chosen (e.g., ownership semantics) or remove theshared_ptrmention.
// Use unique_ptr - more efficient than shared_ptr
gsLookupFunction.h:326
- [nitpick] Holding
m_pointsas a reference risks dangling references if the original matrices go out of scope. Consider using an owning type (shared_ptr/unique_ptr) or ensure callers manage the source lifetime.
const gsMatrix<T>& m_points;
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hverhelst
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_pointsandm_dataingsLookupFunctionSingleto hold references instead of copies, reducing unnecessary data duplication.Containertypedef ingsLookupFunctionto usememory::unique_ptrfor storingPiece_tobjects