Skip to content

Perpendicular flap volume example and shell example - #22

Merged
Crazy-Rich-Meghan merged 7 commits into
mainfrom
volumes
Jul 11, 2025
Merged

Perpendicular flap volume example and shell example#22
Crazy-Rich-Meghan merged 7 commits into
mainfrom
volumes

Conversation

@Crazy-Rich-Meghan

Copy link
Copy Markdown
Contributor

Added two variants for the perpendicular flap example.

  1. Solid participant uses 3D elasticity geometry
  2. Solid participant uses 2D shell represents 3D elasticity

@Crazy-Rich-Meghan Crazy-Rich-Meghan added this to the v25.06.0 milestone Jul 7, 2025
@Crazy-Rich-Meghan Crazy-Rich-Meghan self-assigned this Jul 7, 2025
@Crazy-Rich-Meghan Crazy-Rich-Meghan added the enhancement New feature or request label Jul 7, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds functionality to extrude 2D spline surfaces into 3D volumes and provides two new “perpendicular flap” example applications—one using full 3D elasticity and one using a shell-based approach.

  • Introduce surfaceToVolume utility and a wrapper overload in gsPreCICEUtils.h.
  • Add a PreCICE XML config for the shell-based 3D example.
  • Add two example executables: one for vertex-based 3D elasticity and one for shell-based volume extrusion.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
gsPreCICEUtils.h New surfaceToVolume utility and toVolume wrapper
examples/perpendicular-flap/precice-config-shell-3d.xml Configuration for shell-based coupling example
examples/perpendicular-flap-vertex-gismo-volume.cpp Example using 3D elasticity geometry
examples/perpendicular-flap-shell-gismo.cpp Example using 2D shell representation for 3D volume
Comments suppressed due to low confidence (1)

gsPreCICEUtils.h:500

  • [nitpick] The @see tag references toVolume itself; it should reference surfaceToVolume where the core implementation lives.
 * @see toVolume(const gsTensorBSpline<2, T> &, const gsFunction<T> &)

Comment thread gsPreCICEUtils.h Outdated
Crazy-Rich-Meghan and others added 2 commits July 7, 2025 12:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@hverhelst hverhelst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small changes to the PR. Now it looks good to me.

@Crazy-Rich-Meghan
Crazy-Rich-Meghan merged commit aa3c311 into main Jul 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants