Perpendicular flap volume example and shell example - #22
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds functionality to extrude 2D spline surfaces into 3D volumes and provides two new “perpendicular flap” example applications—one using full 3D elasticity and one using a shell-based approach.
- Introduce
surfaceToVolumeutility and a wrapper overload ingsPreCICEUtils.h. - Add a PreCICE XML config for the shell-based 3D example.
- Add two example executables: one for vertex-based 3D elasticity and one for shell-based volume extrusion.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gsPreCICEUtils.h | New surfaceToVolume utility and toVolume wrapper |
| examples/perpendicular-flap/precice-config-shell-3d.xml | Configuration for shell-based coupling example |
| examples/perpendicular-flap-vertex-gismo-volume.cpp | Example using 3D elasticity geometry |
| examples/perpendicular-flap-shell-gismo.cpp | Example using 2D shell representation for 3D volume |
Comments suppressed due to low confidence (1)
gsPreCICEUtils.h:500
- [nitpick] The
@seetag referencestoVolumeitself; it should referencesurfaceToVolumewhere the core implementation lives.
* @see toVolume(const gsTensorBSpline<2, T> &, const gsFunction<T> &)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hverhelst
approved these changes
Jul 11, 2025
hverhelst
left a comment
Member
There was a problem hiding this comment.
I made some small changes to the PR. Now it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two variants for the perpendicular flap example.