Fix book repository URLs #1877
Merged
Fix book repository URLs #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to indent only with spaces over here. Signed-off-by: Johannes Schindelin <[email protected]>
The URL is already stored in the front matter of the front page of each translation. However, we need it on every page, not just the front page, because the repository link is shown on the bottom of the sidebar. Signed-off-by: Johannes Schindelin <[email protected]>
This trick was performed by letting the freshly-modified `script/book.rb` script do its job. Signed-off-by: Johannes Schindelin <[email protected]>
The repository link worked for the front page of each translation of the book, but not for any other page. Now that the URL is stored in the site-wide data, we can fix this. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fix-book-repository-URLs
branch
from
139c63c to
041f29f
Compare
ttaylorr
approved these changes
Sep 26, 2024
|
From https://github.com/git/git-scm.com/actions/runs/11055205763/job/30713847974:
I did not anticipate PRs to be merged in such rapid succession ;-) Guess we need some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a fix for a regression I introduced in #1804, which I happened to notice while working on something completely different.
Context
On the sidebar of the ProGit book and its translations, there is a link to the repository, to direct eager contributors to the place where they can contribute their changes.
However, I only seem to have tested this with the front pages of the various translations, as the link is bogus on every other page of the book.
An example can be seen e.g. here: https://git-scm.com/book/en/v2/Getting-Started-About-Version-Control. The link "The source of this book is hosted on GitHub." points to itself.
This PR fixes that. Demo: https://dscho.github.io/git-scm.com/book/en/v2/Getting-Started-About-Version-Control (where I branch-deployed this fix).