Upload playwright results in PR builds #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do that in all other workflows that run the Playwright tests, and it is very helpful when diagnosing issues (especially the screenshots that are stored on failure). This needs a slight change in the Playwright configuration where we now want to have the `github` reporter _in addition_ to the `html` reporter (and not instead of it). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For ease of debugging test failures in the Playwright tests, let's upload the results also in PR builds (we already publish them as build artifacts in the
playwrightworkflow as well as when deploying the site).Context
When I was working on #1878, I was puzzled about some test failures in the Playwright tests. When I found out, it was quite obvious that I had forgotten to update the test accordingly, but I had to recreate the test failure locally because the test results had not been made available as a build artifact.