Add Halo5-Stats Spartan Company endpoint. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H5 spartan company endpoints
…le.Company to just compare on Id's.
… match HaloSharp conventions.
….cs Company class to be consistent with Halo5.Model.Stats.SpartanCompany.
… on InvalidGuid. All unit tests passing for GetSpartanCompany and GetPlayerAppearance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Halo5.Stats "Company" endpoint and touches up some consistency in the original GetPlayerAppearance API, mostly swapping capitalization of field names from camelCase to match the API and other classes.
The referenced endpoint is documented at: https://developer.haloapi.com/docs/services/58acdf27e2f7f71ad0dad84b/operations/596968ade2f7f7051870d29f
This gist has some sample usage for the endpoint - https://gist.github.com/C-Kennelly/33d59b01db2a01201399cb41364e059c
Once again, I implemented identical unit tests to GetPlayerAppearance - covering the basics on matching expected URL, returning results that match the schema, and not throwing random exceptions. Probably could use some more tests here, if there's interest.
All unit tests were passing, though I think I missed the compile step that placed the JSON files in the /bin/debug folder and ended up doing copy-step that manually. If that's not IDE specific, you might run into the same problem when you run locally, so heads up.