Caught errors from bad json in object editor fields. #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was an ace editor field whose type was 'object', and the getValue was called when the entered json was invalid, it would throw an error. Wrapped the JSON.parse call in a try catch block and upon failure, it will set it to null.
hardikkaji
approved these changes
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was an ace editor field whose type was 'object', and the getValue was called when the entered json was invalid, it would throw an error.
Wrapped the JSON.parse call in a try catch block and upon failure, it will set it to null.
I would occasionally see this error pop up in our automated error reporter, and then a lot when working on #539, so I made this as well.
Note: the value of
nullseemed like the best value if the JSON is invalid, certainly better than throwing an error, but I'm open to suggestions.