Skip to content

Moving the empty text fix as some were getting through before #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moving the empty text fix as some were getting through before #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/gen-tables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,12 +469,10 @@ export function getSlidesForTableRows (tableRows: TableCell[][] = [], tableProps
// 3: set array of words that comprise this line
const currLine: TableCell[] = srcCell._lines.shift()

// 4: create new line by adding all words from curr line (or add empty if there are no words to avoid "needs repair" issue triggered when cells have null content)
if (Array.isArray(tgtCell.text)) {
if (currLine) tgtCell.text = tgtCell.text.concat(currLine)
else if (tgtCell.text.length === 0) tgtCell.text = tgtCell.text.concat({ _type: SLIDE_OBJECT_TYPES.tablecell, text: '' })
// IMPORTANT: ^^^ add empty if there are no words to avoid "needs repair" issue triggered when cells have null content
}
// 4: create new line by adding all words from curr line
if (Array.isArray(tgtCell.text) && currLine) {
tgtCell.text = tgtCell.text.concat(currLine);
}

// 5: increase table height by the curr line height (if we're on the last column)
if (currCellIdx === rowCellLines.length - 1) emuTabCurrH += emuLineMaxH
Expand All @@ -487,6 +485,17 @@ export function getSlidesForTableRows (tableRows: TableCell[][] = [], tableProps
if (brent === 0) isDone = true
}

// Fill in any empty text cells that may still exist
// NOTE: This fixes the "needs repair" issue when a cell has no text
currTableRow.forEach(function (cell) {
if (Array.isArray(cell.text) && cell.text.length === 0) {
cell.text.push({
_type: SLIDE_OBJECT_TYPES.tablecell,
text: "",
});
}
});

// F: Flush/capture row buffer before it resets at the top of this loop
if (currTableRow.length > 0) newTableRowSlide.rows.push(currTableRow)

Expand Down