Fix table header row for accessibility (Issue #1299) #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reviewed the code, looks fine, I hope this will be merged soon. We need this fix for accessibility. Otherwise the generated PPT has "accessibility warnings" in MS PowerPoint. We'd rather have this PR merged into this project, to avoid creating yet another fork. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accessibility checker built into PowerPoint reports that all tables generated by PPTxGenJS are "Missing Table Header" even the options are set to {autoPage:true, autoPageRepeatHeader:true}. The top row of the table indeed acts like a header visually, but not semantically as far as PowerPoint is concerned. As such, the PPTs fail accessibility testing and are inaccessible for users of assistive technologies such as screen readers.
A simple—and perhaps overly simple—solution was implemented here such that if autoPageRepeatHeader is true, the first row of the table is marked up as a header row when the XML is generated for the PowerPoint file.
Reference issue # 1299 (#1299)