feat: allow controller decorator to accept ElementDefinitionOptions #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HipsterBrown is this effort abandoned? did something change your assessment of the need for this? |
|
@rektide Based on the explanation in the linked issue (#148 (comment)), extending native elements is not a viable addition to this library since Safari won't support it and can be brittle in the long run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
To allow extending native elements with the
@controllerdecorator, this PR allows for passingElementDefinitionOptionsto the decorator and treating it like a decorator factory.Regular usage of the decorator will still work, so this should not be a breaking change.