-
Notifications
You must be signed in to change notification settings - Fork 434
Add git version check for overlay analysis enablement #3370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
aff7998
Initial plan
Copilot 89753aa
Add git version check for overlay analysis enablement
Copilot fc2bbb0
Address code review feedback
Copilot c3dc529
Address feedback: cache git version, improve error handling, add tele…
Copilot 393c074
Refactor existing telemetry diagnostics to use makeTelemetryDiagnostic
Copilot 32795b3
Merge branch 'main' into copilot/update-overlay-git-version-check
henrymercer e052dbd
Remove caching mechanism
henrymercer 3765106
Move git version logging to config utils
henrymercer 9c5588d
Remove unnecessary stub restores
henrymercer 056581e
Update `makeTelemetryDiagnostic` doc
henrymercer a13b404
Record both truncated and full git versions
henrymercer a2c3c8e
Bump log level for failing to parse git version
henrymercer 003ddae
Avoid non-determinism in PR checks due to overlay FFs
henrymercer 358a55e
Throw in test mode if can't compute git version
henrymercer cec3cc5
Trim git version output
henrymercer 948c7fb
Test mode: Tolerate missing git binary
henrymercer ff84c6f
Improve comment
henrymercer a7e88a4
Only enable overlay for the code scanning suite
henrymercer 95246ce
Prefer explicit env var to binary accessibility check
henrymercer 034401b
Merge branch 'main' into copilot/update-overlay-git-version-check
henrymercer 8b428c0
Use `EnvVar`
henrymercer 3b6fef6
Fix import order
henrymercer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added
TOLERATE_MISSING_GIT_VERSIONto theEnvVarenum, but aren't using it here.