Skip to content

Require tools feature for uploading overlay DBs #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 3 commits into from
Dec 18, 2025
Merged

Require tools feature for uploading overlay DBs #3375

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb26a02
Require tools feature for uploading overlay DBs
henrymercer Dec 17, 2025
67e683b
Report bundled DB size in error if known
henrymercer Dec 17, 2025
a2917b0
Check !== undefined rather than truthiness
henrymercer Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/analyze-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src/database-upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ export async function cleanupAndUploadDatabases(
reports.push({
language,
error: util.getErrorMessage(e),
...(bundledDbSize ? { zipped_upload_size_bytes: bundledDbSize } : {}),
...(bundledDbSize !== undefined
? { zipped_upload_size_bytes: bundledDbSize }
: {}),
Comment on lines +148 to +150
Copy link
Member

@mbg mbg Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not equivalent to just

Suggested change
...(bundledDbSize !== undefined
? { zipped_upload_size_bytes: bundledDbSize }
: {}),
zipped_upload_size_bytes: bundledDbSize

Copy link
Contributor Author

@henrymercer henrymercer Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

➜  ~ node
Welcome to Node.js v25.2.1.
Type ".help" for more information.
> let x = {}
undefined
> x["a"] = undefined
undefined
> x
{ a: undefined }

Copy link
Member

@mbg mbg Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but practically speaking there is not typically a difference in using an object with a key that has undefined as value vs a key that is absent. Asking for the value of the key gives undefined in both cases. The question is whether we care about the distinction that the key itself exists or not.

Copy link
Contributor Author

@henrymercer henrymercer Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. I'd prefer to leave this to the future and address it across the codebase.

});
}
}
Expand Down
Loading