Skip to content

Rust: Weak encryption algorithm query. #18226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 18 commits into from
Dec 12, 2024
Merged

Rust: Weak encryption algorithm query. #18226

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bdb2f3d
Rust: Add placeholder query and tests for 'cipher' module.
geoffw0 Dec 3, 2024
6c4e0a9
Rust: A few more test cases.
geoffw0 Dec 3, 2024
07e3421
Rust: Add shared ConceptsShared.qll, CryptoAlgorithms.qll and CryptoA…
geoffw0 Dec 4, 2024
eeeb142
Rust: Implement the query.
geoffw0 Dec 4, 2024
94dbad7
Rust: Model for cipher traits.
geoffw0 Dec 5, 2024
6eb850c
Rust: Improve the model.
geoffw0 Dec 5, 2024
dd0fa79
Rust: Add qhelp.
geoffw0 Dec 5, 2024
de042ea
Merge branch 'main' into badcrypto
geoffw0 Dec 5, 2024
4e418d3
Rust: Update for latest main, and autoformat.
geoffw0 Dec 5, 2024
129f21a
Rust: Make a predicate private.
geoffw0 Dec 6, 2024
f637b3b
Apply suggestions from code review
geoffw0 Dec 6, 2024
4b93325
Merge branch 'main' into badcrypto
geoffw0 Dec 6, 2024
ad75906
Apply suggestions from code review
geoffw0 Dec 11, 2024
591db05
Rust: Formatting.
geoffw0 Dec 11, 2024
d2cfcb4
Update rust/ql/lib/codeql/rust/internal/ConceptsShared.qll
geoffw0 Dec 12, 2024
1d72b75
Rust: data-flow -> data flow.
geoffw0 Dec 12, 2024
611d04e
Rust: Revert stylistic change in shared file.
geoffw0 Dec 12, 2024
44a0ad2
Update data-flow -> data flow in all versions of ConceptsShared.qll.
geoffw0 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/ql/lib/codeql/rust/internal/ConceptsShared.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ module Cryptography {
class PasswordHashingAlgorithm = CryptoAlgorithms::PasswordHashingAlgorithm;

/**
* A data-flow node that is an application of a cryptographic algorithm. For example,
* A data flow node that is an application of a cryptographic algorithm. For example,
Copy link
Contributor

@aibaars aibaars Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the sync'd copies as well.

Copy link
Contributor Author

@geoffw0 geoffw0 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you happy that we do that? I didn't want to interfere with other languages unless there's some level of agreement.

Copy link
Contributor

@aibaars aibaars Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with that, although if you like to leave things as-is, that's also fine with me.

Copy link
Contributor Author

@geoffw0 geoffw0 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the change.

* encryption, decryption, signature-validation.
*
* Extend this class to refine existing API models. If you want to model new APIs,
Expand Down
Loading