Rust: Shorthand record construction in data flow #18700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/shorthand-struct
branch
from
dea88a0 to
1685a34
Compare
hvitved
force-pushed
the
rust/shorthand-struct
branch
from
1685a34 to
707bf16
Compare
Contributor
There was a problem hiding this comment.
PR Overview
This pull request introduces shorthand record construction in the Rust dataflow tests to simplify variable assignment and improve readability. Key updates include the introduction of a local variable "y" and the use of a shorter struct field initialization syntax for "plane".
- Declares a local variable "y" by calling the "source" function
- Replaces the inline "source(93)" call with "y" in the "Point" struct initialization
Changes
| File | Description |
|---|---|
| rust/ql/test/library-tests/dataflow/local/main.rs | Uses a local variable for record initialization, simplifying the struct field assignment logic |
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
paldepind
requested changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #18656, but for constructions instead of destructions.