Rust: Make source kinds consistent with other languages

[geoffw0]

Make source kinds consistent with other languages and https://github.com/github/codeql/blob/main/docs/codeql/reusables/threat-model-description.rst . Somehow we ended up with different strings for environment and commandargs sources.

[Copilot]

Pull Request Overview

This pull request updates the source kind strings in the Rust standard library environment model to align with naming conventions used in other languages and the CodeQL threat model documentation.

• Renames command-line source kinds to "commandargs".
• Renames environment source kinds to "environment".

Files not reviewed (4)

• rust/ql/lib/codeql/rust/Concepts.qll: Language not supported
• rust/ql/test/query-tests/security/CWE-020/RegexInjection.expected: Language not supported
• rust/ql/test/query-tests/security/CWE-089/SqlInjection.expected: Language not supported
• rust/ql/test/query-tests/security/CWE-770/UncontrolledAllocationSize.expected: Language not supported

Comments suppressed due to low confidence (2)

rust/ql/lib/codeql/rust/frameworks/stdlib/env.model.yml:6

• [nitpick] The source kind 'commandargs' replaces the previous 'command-line-source'. Confirm that this naming is consistently applied across the codebase and aligns with our naming conventions as referenced in the documentation.

      - ["lang:std", "crate::env::args", "ReturnValue.Element", "commandargs", "manual"]

rust/ql/lib/codeql/rust/frameworks/stdlib/env.model.yml:11

• [nitpick] The renaming to 'environment' updates the prior 'environment-source'. Please verify that all external references and documentation are updated to reflect this change.

      - ["lang:std", "crate::env::var", "ReturnValue.Field[crate::result::Result::Ok(0)]", "environment", "manual"]

[aibaars]

Nice!