Rust: upgrade `rust-analyzer` to 0.0.288 #19524

redsun82 · 2025-05-19T15:18:31Z

No description provided.

geoffw0

QL changes LGTM.

I've raised some questions on the DCA run, it looks like a net gain but there are some regressions in there that deserve discussing.

Extractor changes not reviewed.

rust/ql/test/library-tests/type-inference/type-inference.expected

aibaars · 2025-06-05T10:45:52Z

Looks good to me. The additional path resolution inconsistencies are a bit annoying though. Any idea where they come from?

geoffw0 · 2025-06-05T11:05:24Z

Judging by the second DCA run it looks like we're extracting significantly fewer files successfully as well - though the run did fail so I don't want to read too much into that.

redsun82 · 2025-06-05T11:06:18Z

Don't know, there are still loads of unexpanded macros around :sigh:

redsun82 · 2025-06-05T11:08:12Z

I've opened rust-lang/rust-analyzer#19931 (as I couldn't reopen rust-lang/rust-analyzer#19873).

redsun82 · 2025-06-13T16:26:37Z

oh well, there's a weird path resolution test error I'll need to look into on Monday :sigh:

aibaars

Looks good to me.

aibaars · 2025-06-20T15:58:31Z

misc/codegen/templates/ql_parent.mustache

@@ -63,7 +63,7 @@ none()
 {{#classes}}
    {{#final}}
        or
-        result = getImmediateChildOf{{name}}(e, index, partialAccessor)
+        index = min(int i | result = getImmediateChildOf{{name}}(e, i, partialAccessor) | i)


Let's revert this change.

rust/ast-generator/src/main.rs

aibaars · 2025-06-20T16:18:26Z

rust/extractor/src/translate/base.rs

-                if err.span().anchor.file_id == semantics.hir_file_for(node.syntax()) {
+                let hir_file_id = semantics.hir_file_for(node.syntax());
+                if Some(err.span().anchor.file_id.file_id())
+                    == hir_file_id.file_id().map(|f| f.file_id(semantics.db))


how did you figure out that you needed the file_id of the file_id of the file_id of file_id ? ;-)

turtles all the way down... 🤷

aibaars · 2025-06-20T16:20:08Z

rust/extractor/src/translate/base.rs

@@ -363,10 +361,10 @@ impl<'a> Translator<'a> {
            .as_ref()
            .and_then(|s| s.expand_macro_call(mcall))
        {
-            self.emit_macro_expansion_parse_errors(mcall, &expanded);
+            self.emit_macro_expansion_parse_errors(mcall, &expanded.value);


Does expanded also have an err field? If so, let log it, hopefully it'll provide some useful information of why an expansion failed?

yes, the latest version of the PR does that

rust/extractor/src/translate/base.rs

rust/ql/test/library-tests/dataflow/sources/InlineFlow.expected

aibaars · 2025-06-23T11:12:15Z

Don't forgot to commit empty expected files for

  FAILED: /home/runner/work/semmle-code/semmle-code/ql/rust/ql/test/extractor-tests/generated/Const/Const_getGenericParamList.ql
  FAILED: /home/runner/work/semmle-code/semmle-code/ql/rust/ql/test/extractor-tests/generated/Const/Const_getWhereClause.ql

hvitved · 2025-06-23T17:54:30Z

rust/ql/test/extractor-tests/macro-expansion/test.expected

 warnings
+| included/included.rs:1:1:1:1 | semantic analyzer unavailable (not loaded as its own module, probably included by `!include`) |
+| macro_expansion.rs:56:9:56:31 | macro expansion failed: could not resolve macro 'concat' |


Does these changes mean we expand fewer macros?

Yes, it does unfortunately. It is likely that the cause is the same as for rust-lang/rust-analyzer#20037 . See also the DCA report for more insight in the impact.

github-actions bot added the Rust Pull requests that update Rust code label May 19, 2025

redsun82 force-pushed the redsun82/cargo-upgrade-3 branch from cc2e8ab to 28b504a Compare May 26, 2025 14:21

github-actions bot added the documentation label May 26, 2025

redsun82 changed the title ~~Rust: upgrade rust-analyzer to 0.0.279~~ Rust: upgrade rust-analyzer to 0.0.281 May 26, 2025

redsun82 mentioned this pull request May 27, 2025

Rust: upgrade rust-analyzer to 0.0.274 #19314

Closed

geoffw0 reviewed May 28, 2025

View reviewed changes

rust/ql/test/library-tests/type-inference/type-inference.expected Outdated Show resolved Hide resolved

redsun82 changed the title ~~Rust: upgrade rust-analyzer to 0.0.281~~ Rust: upgrade rust-analyzer to 0.0.285 Jun 4, 2025

redsun82 marked this pull request as ready for review June 4, 2025 12:12

redsun82 requested review from a team as code owners June 4, 2025 12:12

redsun82 marked this pull request as draft June 12, 2025 15:37

redsun82 changed the title ~~Rust: upgrade rust-analyzer to 0.0.285~~ Rust: upgrade rust-analyzer to 0.0.287 Jun 13, 2025

redsun82 marked this pull request as ready for review June 13, 2025 15:58

redsun82 marked this pull request as draft June 13, 2025 16:26

github-actions bot added the Swift label Jun 17, 2025

redsun82 marked this pull request as ready for review June 17, 2025 11:51

redsun82 requested a review from a team as a code owner June 17, 2025 11:51

redsun82 marked this pull request as draft June 17, 2025 11:51

redsun82 added the no-change-note-required This PR does not need a change note label Jun 17, 2025

redsun82 changed the title ~~Rust: upgrade rust-analyzer to 0.0.287~~ Rust: upgrade rust-analyzer to 0.0.288 Jun 20, 2025

redsun82 added 5 commits June 20, 2025 17:34

Bazel/Rust: Change rust version

2c14f27

Cargo: run upgrade

ce29d8a

Bazel: regenerate cargo vendored files

492b0cd

Rust: suppress TypeAnchor in the generator

12aa93b

Rust: rerun codegen

efd318d

redsun82 added 2 commits June 20, 2025 17:52

Rust: fix compilation errors

02a9d4c

Rust: suppress some expected macro expansion warnings

7edae1e

redsun82 force-pushed the redsun82/cargo-upgrade-3 branch from 5cf6b5c to 7edae1e Compare June 20, 2025 15:58

github-actions bot removed documentation Swift labels Jun 20, 2025

Cargo: fix Cargo.lock file

5b4c566

aibaars reviewed Jun 20, 2025

View reviewed changes

aibaars and others added 6 commits June 20, 2025 19:07

Merge branch 'main' into redsun82/cargo-upgrade-3

089f353

Merge branch 'main' into redsun82/cargo-upgrade-3

d303a2c

Rust: fix Meta missing post_emit! implementation

3ffaf57

Rust: accept test changes for now

eb3b717

Merge branch 'main' into redsun82/cargo-upgrade-3

377fb00

Rust: remove unneeded rustc_apfloat patch

8f9c031

aibaars reviewed Jun 23, 2025

View reviewed changes

rust/extractor/src/translate/base.rs Outdated Show resolved Hide resolved

Rust: accept test changes

84de91b

aibaars reviewed Jun 23, 2025

View reviewed changes

rust/ql/test/library-tests/dataflow/sources/InlineFlow.expected Outdated Show resolved Hide resolved

Rust: address review and test failure

cbd62a8

aibaars force-pushed the redsun82/cargo-upgrade-3 branch from 190ab52 to 1823a22 Compare June 23, 2025 11:34

redsun82 mentioned this pull request Jun 23, 2025

Rust: regenerate models after rust-analyzer update #19848

Draft

Rust: add upgrade/downgrade scripts for new tables

13b28e2

aibaars force-pushed the redsun82/cargo-upgrade-3 branch from 1823a22 to 13b28e2 Compare June 23, 2025 12:36

Rust: fix DB upgrade/downgrade scripts

5162d2c

redsun82 marked this pull request as ready for review June 23, 2025 13:00

Merge branch 'main' into redsun82/cargo-upgrade-3

823ac5c

aibaars approved these changes Jun 23, 2025

View reviewed changes

redsun82 merged commit 29b37a4 into main Jun 23, 2025
59 checks passed

redsun82 deleted the redsun82/cargo-upgrade-3 branch June 23, 2025 15:43

hvitved reviewed Jun 23, 2025

View reviewed changes

Rust: upgrade rust-analyzer to 0.0.288 #19524

Rust: upgrade rust-analyzer to 0.0.288 #19524

Conversation

redsun82 commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoffw0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibaars commented Jun 5, 2025

Uh oh!

geoffw0 commented Jun 5, 2025

Uh oh!

redsun82 commented Jun 5, 2025

Uh oh!

redsun82 commented Jun 5, 2025

Uh oh!

redsun82 commented Jun 13, 2025

Uh oh!

aibaars left a comment

Choose a reason for hiding this comment

Uh oh!

aibaars Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aibaars Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

redsun82 Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

aibaars Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

redsun82 Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aibaars commented Jun 23, 2025

Uh oh!

Uh oh!

hvitved Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

aibaars Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rust: upgrade `rust-analyzer` to 0.0.288 #19524

Rust: upgrade `rust-analyzer` to 0.0.288 #19524

redsun82 commented May 19, 2025 •

edited

Loading