C++: Support more complex 16-bit float types #19862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jketema
force-pushed
the
complex
branch
2 times, most recently
from
4159bce to
2843a59
Compare
jketema
commented
Jun 24, 2025
Comment on lines
+339
to
+350
| <e> | ||
| <k>@complex_fp16</k> | ||
| <v>124</v> | ||
| </e> | ||
| <e> | ||
| <k>@complex_std_bfloat16</k> | ||
| <v>124</v> | ||
| </e> | ||
| <e> | ||
| <k>@complex_std_float16</k> | ||
| <v>124</v> | ||
| </e> |
Contributor
Author
There was a problem hiding this comment.
Note that I just hacked this in, as stats file generation is currently broken. I do a proper update once that is fixed.
jketema
added
the
depends on internal PR
IdrissRio
approved these changes
Jun 24, 2025
Contributor
IdrissRio
left a comment
IdrissRio
left a comment
There was a problem hiding this comment.
Small comment otherwise LGTM
Contributor
|
Approving - assuming this will not merge before checks are green :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.