Skip to content

Rust: Apply inherent method prioritization inside type inference loop #19903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 3 commits into from
Jul 1, 2025
Merged

Rust: Apply inherent method prioritization inside type inference loop #19903

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f0ef6
Rust: Add more type inference tests
hvitved Jun 25, 2025
e88d7ba
Rust: Apply inherent method prioritization inside type inference loop
hvitved Jun 27, 2025
0723391
Rust: Update expected test output
hvitved Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rust/ql/test/library-tests/dataflow/models/CONSISTENCY/PathResolutionConsistency.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
multipleCallTargets
| main.rs:362:14:362:30 | ... .lt(...) |
2 changes: 1 addition & 1 deletion rust/ql/test/library-tests/dataflow/sources/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ fn test_io_stdin() -> std::io::Result<()> {
{
let mut buffer = Vec::<u8>::new();
let _bytes = std::io::stdin().read_to_end(&mut buffer)?; // $ Alert[rust/summary/taint-sources]
sink(&buffer); // $ MISSING: hasTaintFlow
sink(&buffer); // $ hasTaintFlow -- @hvitved: works in CI, but not for me locally
Copy link
Contributor

@geoffw0 geoffw0 Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. I've written an issue to look into this, my suspicion is that when we finish updating all the models and then generalize what we can to trait models, the platform specific behaviours are going to go away.

}

{
Expand Down
Loading