Skip to content

C#: Tracer support for invoking csc directly. #20663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 8 commits into from
Oct 22, 2025
Merged

C#: Tracer support for invoking csc directly. #20663

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e560ac1
C#: Tracer support for invoking csc directly.
michaelnebel Oct 21, 2025
6bc15bc
C#: Add change-note.
michaelnebel Oct 21, 2025
af5622a
C#: Address review comments.
michaelnebel Oct 21, 2025
def522d
C#: Make sure that the file exists before attempting to get version i…
michaelnebel Oct 21, 2025
d5ff9bf
C#: Collapse tracer cases for csc, csc.exe and mcs.exe and remote quo…
michaelnebel Oct 22, 2025
e14879b
C#: Add integration test for DB creation using .NET 10 RC 2.
michaelnebel Oct 22, 2025
7a41408
C#: Use autobuilder instead of supplying build command.
michaelnebel Oct 22, 2025
47c751b
C#: Only run integration test on windows and linux.
michaelnebel Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion csharp/extractor/Semmle.Extraction.CSharp/Extractor/CompilerVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public CompilerVersion(Options options)
specifiedFramework = compilerDir;
}

var versionInfo = FileVersionInfo.GetVersionInfo(SpecifiedCompiler);
// If csc is specified as compiler name, then attempt to read the version information from csc.dll
var compilerBinaryName = SpecifiedCompiler.EndsWith("csc") ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EndsWith check is too broad and could incorrectly match paths ending with 'csc' that aren't the compiler binary (e.g., /path/to/misc). Use Path.GetFileNameWithoutExtension(SpecifiedCompiler) == "csc" to ensure only the actual csc compiler binary is matched.

Suggested change
var compilerBinaryName = SpecifiedCompiler.EndsWith("csc") ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;
var compilerBinaryName = Path.GetFileNameWithoutExtension(SpecifiedCompiler) == "csc" ? $"{SpecifiedCompiler}.dll" : SpecifiedCompiler;

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@michaelnebel michaelnebel Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion - we do however need to take the file extension into account.

Copy link
Contributor Author

@michaelnebel michaelnebel Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we also need to make sure not to read the version information from a non-existing file 😄

var versionInfo = FileVersionInfo.GetVersionInfo(compilerBinaryName);
if (!knownCompilerNames.TryGetValue(versionInfo.OriginalFilename ?? string.Empty, out var vendor))
{
SkipExtractionBecause("the compiler name is not recognised");
Expand Down
4 changes: 4 additions & 0 deletions csharp/ql/lib/change-notes/2025-10-21-dotnet-rc2-tracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added tracer support for macOS and Linux when the .NET CLI (`dotnet`) directly invokes the C# compiler (`csc`). This enhancement provides basic tracing and extraction capabilities for .NET 10 RC2 on these platforms.
5 changes: 5 additions & 0 deletions csharp/tools/tracing-config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ function RegisterExtractorPack(id)
prepend = { '--compiler', '"${compiler}"' },
order = ORDER_BEFORE
}),
CreatePatternMatcher({ '^csc$' }, MatchCompilerName,
Copy link
Contributor

@hvitved hvitved Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just include '^csc$' in the list above?

Copy link
Contributor Author

@michaelnebel michaelnebel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the quotation in the above.

Copy link
Contributor Author

@michaelnebel michaelnebel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our offline discussion, the matchers have been merged, which means that the quotation has been removed for the .exe cases.

extractor, {
prepend = { '--compiler', '${compiler}' },
order = ORDER_BEFORE
}),
MsBuildMatcher,
function(compilerName, compilerPath, compilerArguments, _languageId)
-- handle cases like `dotnet exec csc.dll <args>` and `mono(-sgen64) csc.exe <args>`
Expand Down