Fix Go extractor incorrectly excluding packages with .. in relative paths #20675
+87
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where cross-module workspace dependencies were incorrectly excluded from extraction.
Problem
When using
go.workworkspaces with multiple modules:wantedRoots..paths → excludedExample
Solution
Add ModDir to
wantedRootsfor all packages (6-line change in type extraction loop).Testing
Integration test at
go/ql/integration-tests/package-exclusion-fix/:Run:
pytest go/ql/integration-tests/package-exclusion-fix/Impact
Low risk, high value for multi-module workspaces, backward compatible.