-
Notifications
You must be signed in to change notification settings - Fork 1.9k
JS: Incremental API graph #20733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asgerf
wants to merge
41
commits into
github:main
Choose a base branch
from
asgerf:js/incremental-api-graphs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
JS: Incremental API graph #20733
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8ea5fc7
JS: Stop dependeding on getPath() for toString()
asgerf 8212bf4
JS: Make MkSyntheticCallbackArg() independent of trackUseNode
asgerf 4ca39e4
JS: Make other node types not depend on tracking predicates
asgerf ce07c8a
JS: Make use() and rhs() uncached and private
asgerf 9e1ab62
JS: Wrap in a module
asgerf a59e280
JS: Parameterise the module (still only one instantiation)
asgerf fed9be9
JS: Moving 'cache' annotations outside the parameterised module
asgerf 8eb33cc
JS: Localize charpred of API::EntryPoint
asgerf 38f1436
JS: Localize MkModuleExport
asgerf 3c0d8bb
JS: Localize MkModuleImport
asgerf c0f27b2
JS: Localize MkClassInstance
asgerf 17b0bcc
JS: Use forceLocal to localize MkTypeUse
asgerf 329cb28
JS: Remove unused predicate
asgerf 93333c0
JS: Make API nodes and labels local
asgerf 6a15594
JS: Improve join order at MkUse call
asgerf 85ee446
JS: Add missing def-node roots
asgerf 9c7d636
JS: Call forceLocal on the output of Stage 1
asgerf 00a4964
JS: Also expose "any state" version of tracking predicates
asgerf 1e50800
JS: Restrict Stage1 to the base database
asgerf 965f433
JS: Add overlay-specific Stage2
asgerf a54f881
JS:Add more member labels
asgerf 79a751c
JS: Add debug tools for detecting lost nodes/edges
asgerf 13fccbe
JS: Change signature of 'edges' to support quick eval
asgerf 7b0ee6f
JS: Add back CallReceiverStep() restriction
asgerf eecfe15
JS: Remove global dependency that wasnt needed anyway
asgerf 4cc3078
JS: Add overlay[global] to abstract classes with fields
asgerf 11bba68
JS: Include import paths from custom ModuleImportNode::Range subclasses
asgerf 98bf9ce
JS: Bugfix in Stage1Local::trackDefNode
asgerf f941358
JS: Simplify toString()
asgerf 807c8b6
JS: Update test output to reflect Node.toString() change
asgerf 1dfb5a1
JS: Work around an issue with overlay-invariance
asgerf 47a6627
JS: Add back promisify-all support
asgerf 9751a33
JS: Make API::Node overlay[local?]
asgerf f132dd5
JS: Sync ApiGraphModels.qll
asgerf f751754
JS: Fix some QL4QL alerts
asgerf 5fbf877
JS: Add a missing needsDefNode restriction
asgerf 6b14789
JS: Fix bad join in export logic
asgerf 0a241e2
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf 4aa1368
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf 1bfbe41
Update javascript/ql/lib/semmle/javascript/ApiGraphs.qll
asgerf 8e1dac0
JS: Rename "in scope" to "in active file"
asgerf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 3 additions & 3 deletions
6
javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| testFailures | ||
| ambiguousPreferredPredecessor | ||
| | pack2/lib.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getInstance() | | ||
| | pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") | | ||
| | pack2/main.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("MainClass").getInstance() | | ||
| | pack2/lib.js:1:1:3:1 | instance of class A ... ethod\\n} | | ||
| | pack2/lib.js:8:22:8:34 | def function() {} | | ||
| | pack2/main.js:1:1:3:1 | instance of class A ... ethod\\n} | | ||
| ambiguousSinkName | ||
| ambiguousFunctionName | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity that we lose the "descriptive" names for API graph nodes, but I guess it's kind of necessary.