Skip to content

Clarify Path.Combine call behavior #21038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 9 commits into from
Dec 18, 2025
+9 −4
Merged

Clarify Path.Combine call behavior #21038

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f6e3e19
Clarify Path.Combine call behavior in documentation
jonjanego Dec 15, 2025
bd9b657
Update csharp/ql/src/Bad Practices/PathCombine.ql
jonjanego Dec 15, 2025
84a501d
Update csharp/ql/src/Bad Practices/PathCombine.ql
jonjanego Dec 16, 2025
30673a2
Enhance PathCombine metadata with detailed description
jonjanego Dec 16, 2025
576f270
Update PathCombine.ql
jonjanego Dec 16, 2025
7423f6f
Fix typo in warning message for Path.Combine
jonjanego Dec 17, 2025
e36b602
Enhance PathCombine.ql metadata details
jonjanego Dec 17, 2025
425d62c
Update PathCombine metadata for clarity
jonjanego Dec 17, 2025
a3c0082
Update PathCombine.expected
jonjanego Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions csharp/ql/src/Bad Practices/PathCombine.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* @name Call to System.IO.Path.Combine
* @description Finds calls to System.IO.Path's Combine method
* @name Call to 'System.IO.Path.Combine' may silently drop its earlier arguments
* @description 'Path.Combine' may silently drop its earlier arguments
* if its later arguments are absolute paths.
* @kind problem
* @problem.severity recommendation
* @precision very-high
Expand All @@ -15,4 +16,4 @@ import semmle.code.csharp.frameworks.System

from MethodCall call
where call.getTarget().hasFullyQualifiedName("System.IO", "Path", "Combine")
select call, "Call to 'System.IO.Path.Combine'."
select call, "Call to 'System.IO.Path.Combine' may silently drop its earlier arguments."
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2025-12-16-path-combine-metadata.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: queryMetadata
---
* Updated the `name`, `description`, and alert message of PathCombine.ql to have more details about why it's a problem.