Skip to content

Rust: Improve and rename Adt class #21059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paldepind merged 8 commits into from
Dec 18, 2025
+15,174 −799

Rust: Revert accidental changes

96a9862
Select commit
Loading
Failed to load commit list.
Merged

Rust: Improve and rename Adt class #21059

Rust: Revert accidental changes
96a9862
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Dec 18, 2025 in 10s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 13 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 33 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArrayExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AsmExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AwaitExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BecomeExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BinaryExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BlockExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.BreakExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CallExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Callable
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CastExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ContinueExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternBlock
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternCrate
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FieldExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IdentPat
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IndexExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LetStmt
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LifetimeParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LiteralExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LoopExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroCall
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArm
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchArmList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MatchExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MethodCallExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Module
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.OffsetOfExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParamBase
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ParenExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PrefixExpr
Loading
.
Redundant import, the module is already imported ins

Check warning on line 75 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForBinder
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Function
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Trait
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.

Check warning on line 82 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.AsmExpr
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.AssocItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternBlock
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternCrate
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ItemList
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroItems
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Module
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SourceFile
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Trait
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Use
Loading
.

Check warning on line 101 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Item
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.

Check warning on line 113 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.AsmOperandNamed
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ConstParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FormatArgsArg
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Function
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.IdentPat
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Module
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Rename
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SelfParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Static
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StructField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Trait
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeParam
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Variant
Loading
.

Check warning on line 189 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ExternCrate
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Function
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroDef
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.MacroRules
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Module
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Static
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StructField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Trait
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleField
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Use
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Variant
Loading
.

Check warning on line 190 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Const
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Function
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Impl
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Trait
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeAlias
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TypeItem
Loading
.

Check warning on line 201 in rust/ql/lib/codeql/rust/elements.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Enum
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Struct
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.Union
Loading
.

Check warning on line 9 in rust/ql/lib/codeql/rust/elements/TypeItem.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.MacroItems
Loading
.

Check warning on line 10 in rust/ql/lib/codeql/rust/elements/TypeItem.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Item
Loading
.

Check warning on line 29 in rust/ql/test/extractor-tests/generated/Enum/Enum.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.

Check warning on line 21 in rust/ql/test/extractor-tests/generated/Struct/Struct.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.

Check warning on line 29 in rust/ql/test/extractor-tests/generated/Union/Union.ql

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.