Unified: Minor style tweak for plugin import. - #22591
Open
aschackmull wants to merge 1 commit into
Open
aschackmull wants to merge 1 commit into
aschackmull wants to merge 1 commit into
Conversation
aschackmull
added
the
no-change-note-required
asgerf
approved these changes
Sep 16, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review tier: Lite (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
What changed in this PR
This pull request refines reverse plugin imports by encapsulating them in private modules, preventing scope pollution while preserving plugin activation.
Changes:
- Isolate the Swift name-binding plugin import.
- Isolate the Swift data-flow plugin import.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll |
Encapsulates the Swift name-binding import. |
unified/ql/lib/codeql/unified/internal/dataflow/DataFlowPlugin.qll |
Encapsulates the Swift data-flow import. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is, I think, the best practice pattern for reverse imports like this. It makes it clear that the import is only about plugin activation and not about putting anything in scope.