-
Notifications
You must be signed in to change notification settings - Fork 1.3k
all SDKs: add EnableExperimentalMode to session create/resume wire with mode-aware defaults #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
982ddfc
d2b8848
c70d1da
1e90676
b0e6ce6
a2a56cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2474,6 +2474,7 @@ protected SessionConfigBase(SessionConfigBase? other) | |
| OnUserInputRequest = other.OnUserInputRequest; | ||
| Provider = other.Provider; | ||
| EnableSessionTelemetry = other.EnableSessionTelemetry; | ||
| IsExperimentalMode = other.IsExperimentalMode; | ||
| SkipCustomInstructions = other.SkipCustomInstructions; | ||
| CustomAgentsLocalOnly = other.CustomAgentsLocalOnly; | ||
| CoauthorEnabled = other.CoauthorEnabled; | ||
|
|
@@ -2639,6 +2640,17 @@ protected SessionConfigBase(SessionConfigBase? other) | |
| /// </summary> | ||
| public bool? EnableSessionTelemetry { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Overrides the session's experimental feature-flag tier resolution. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Phrase as Also make this respect the session's
Do this consistently across all languages.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in b0e6ce6. |
||
| /// </summary> | ||
| /// <remarks> | ||
| /// Set to <see langword="true"/> to force-enable the experimental tier for this | ||
| /// session, or <see langword="false"/> to resolve feature flags as if | ||
| /// experimental were off. Leave <see langword="null"/> to inherit the runtime | ||
| /// process defaults unchanged. | ||
| /// </remarks> | ||
| public bool? IsExperimentalMode { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// When <see langword="true"/>, suppresses loading of custom instruction files | ||
| /// (e.g. <c>.github/copilot-instructions.md</c>, <c>AGENTS.md</c>) from the working directory. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Rename to
EnableExperimentalModeand the equivalent across 6 languages. Obviously you can't change the name on the wire - I just mean rename it in the SDK's API surface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 1e90676. Renamed the public SDK API surface to
EnableExperimentalMode(language-appropriate casing) across Rust, Node.js, Python, Go, .NET, and Java while keeping the wire field name asisExperimentalMode.