fix: default python session.log level to info#819
Closed
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Closed
fix: default python session.log level to info#819haosenwang1018 wants to merge 1 commit intogithub:mainfrom
haosenwang1018 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
|
Thanks @haosenwang1018 but I'd rather not make this change because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopilotSession.log()sendlevel="info"when callers omit thelevelargumentWhy
Fixes #810. The public Python API documents
levelas defaulting to"info", but the current implementation omitslevelfrom the RPC entirely when the caller does not pass it. This PR aligns the implementation with the documented/default API contract.Validation
python -m pytest -q python/test_client.py -k 'log_uses_info_level_by_default'git diff --check