[jsweep] Clean messages_core.cjs

[github-actions]

Summary

Cleaned actions/setup/js/messages_core.cjs and added a comprehensive test suite.

Context type: github-script (uses core global)

---

Changes

messages_core.cjs

1. Moved lazy require() to top-level import — error_helpers.cjs was required inside getMessages() on every call. There's no circular dependency, so it belongs at the module top level like all other imports.

2. Simplified toSnakeCase() with Object.fromEntries + flatMap — replaced the imperative for loop + two assignments with a functional one-liner. The new version also avoids duplicate entries when a key is already in snake_case (e.g. run_url previously got assigned twice):

   // Before
   const result = {};
   for (const [key, value] of Object.entries(obj)) {
     const snakeKey = key.replace(/([A-Z])/g, "_$1").toLowerCase();
     result[snakeKey] = value;
     result[key] = value;  // duplicate if already snake_case
   }
   
   // After
   return Object.fromEntries(
     Object.entries(obj).flatMap(([key, value]) => {
       const snakeKey = key.replace(/([A-Z])/g, "_$1").toLowerCase();
       return snakeKey === key ? [[key, value]] : [[snakeKey, value], [key, value]];
     })
   );

messages_core.test.cjs (new file)

Added 17 tests covering all three exported functions:

Group	Tests
renderTemplate	single placeholder, multiple placeholders, missing key preserved, undefined value preserved, numeric coercion, boolean coercion, no placeholders, empty template
toSnakeCase	camelCase→snake_case, original key preserved, no duplicates for snake_case input, multi-word conversion, empty object, mixed input
getMessages	null when unset, null when empty, valid JSON parsed, multiple fields parsed, invalid JSON warns + returns null

---

Validation ✅

• Formatting: npm run format:cjs ✓
• Linting: npm run lint:cjs ✓
• Type checking: npm run typecheck ✓
• Tests: npm run test:js ✓ (all 17 new tests pass; existing failures are pre-existing environment issues unrelated to this change)

Generated by jsweep - JavaScript Unbloater · ◷

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

• expires on Mar 14, 2026, 3:31 AM UTC

[github-actions]

🤖 Contribution Check — [jsweep] Clean messages_core.cjs

Nice work on this cleanup! The messages_core.cjs refactor is tight and well-reasoned — promoting the lazy require() to the module top level is the right call, and the flatMap/Object.fromEntries rewrite of toSnakeCase is cleaner while also fixing the latent duplicate-key bug for already-snake_case inputs. The 17-test suite covers all three exported functions with good boundary cases.

Checklist summary:

Check	Result
On-topic	✅ yes — aligns with agentic JS cleanup tooling
Follows process	✅ yes — agentic PR via core team automation
Focused	✅ yes — single module refactor + tests
New dependencies	✅ no
Has tests	✅ yes — 17 tests across all exported functions
Has description	✅ yes — thorough summary with before/after code
Lines changed	198 (184 additions, 14 deletions)

Verdict: 🟢 Aligned — this PR looks ready for maintainer review!

Generated by Contribution Check · ◷

[Copilot]

Pull request overview

Cleans up messages_core.cjs by hoisting a lazy require() to the module top level and simplifying toSnakeCase() using Object.fromEntries/flatMap, while also fixing a subtle duplicate-entry bug for already-snake_case keys. A comprehensive test suite is added.

Changes:

• Moved require("./error_helpers.cjs") from inside getMessages() to the top of the module.
• Rewrote toSnakeCase() as a functional one-liner that avoids duplicate entries for keys already in snake_case.
• Added 17 new tests covering renderTemplate, toSnakeCase, and getMessages.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
actions/setup/js/messages_core.cjs	Hoisted import; simplified toSnakeCase(); updated JSDoc comments.
actions/setup/js/messages_core.test.cjs	New test suite covering all three exported functions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.