Skip to content

Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely #1574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaaec7e
Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely.
grodowski Jul 9, 2025
5fbb66e
Merge branch 'master' into grodowski/panic-on-heartbeat-writer-retrie…
grodowski Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/logic/applier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,7 @@ func (this *Applier) InitiateHeartbeat() {
continue
}
if err := injectHeartbeat(); err != nil {
this.migrationContext.PanicAbort <- fmt.Errorf("injectHeartbeat writing failed %d times, last error: %w", numSuccessiveFailures, err)
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable numSuccessiveFailures is referenced but not visible in this diff. Ensure this variable is properly defined and incremented in the retry logic to accurately reflect the number of failures.

Copilot uses AI. Check for mistakes.

return
}
}
Expand Down