Skip to content
This repository was archived by the owner on Apr 21, 2022. It is now read-only.

Escape repo descriptions #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

brandonrosage
Copy link
Collaborator

This PR escapes repo descriptions as displayed in their card.

Does it solve your problem, @enriquemorenotent?

Closes #56

@enriquemorenotent
Copy link

I'm not sure how to test this. I already forked and deployed mine at https://enriquemorenotent.github.io using master.

Could you give me some pointers on how to check it?

@brandonrosage
Copy link
Collaborator Author

Sure thing. You can "merge an upstream repository into your fork". It'll look something like this:

$ git pull https://github.com/github/personal-website.git YOUR_REPO_BRANCH_NAME

It effectively merges the latest from the original github/personal-website into your repo's current branch. Hope that helps 👍

@enriquemorenotent
Copy link

But that will merge the latest changes of "master" from the original repo to my forked "master", no?

What I need is to test the changes from the original repo in escape-repo-descriptions inside my forked "master2, no?

@brandonrosage
Copy link
Collaborator Author

I'm sorry, I screwed up the instructions.

The branch name at the end of that command should be the name of the branch in the upstream repo that you wish to merge into your repo. So, you'd switch to the desired branch in your repo and then literally enter:

$ git pull https://github.com/github/personal-website.git escape-repo-descriptions

That will merge the code from this PR in github/personal-website into your local repo. Cool?

@enriquemorenotent
Copy link

Locally seems to work, but for some reason it is not updating online, which brings me to an interesting question...

If I updated the description of a repository, how do I trigger an update of the website, without having to make an empty commit?

@JamesIves
Copy link
Contributor

JamesIves commented Mar 9, 2019

Looks good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants