Skip to content

Add a free shipping promo highlight #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lupas_calin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a free shipping promo highlight #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd17cd5
Add a free shipping promo highlight AB#1639
Jul 6, 2026
1c1abe2
Merge branch 'main' into feature/free-shipping-banner - resolve confl…
Copilot Jul 6, 2026
dd23478
Update highlights for home page promotions
CalinL Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Web/HomeContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace GhAdoE2eDemo.Web;

Check failure on line 1 in src/Web/HomeContent.cs

View check run for this annotation

ai-sdlc-pr-review-agent / PR Review Agent

[CRITICAL] Missing test coverage for behavior change 

This change adds a new highlight to the home page, which is a user-visible behavior change. Per review-policy.yml (requireTests: true) and AGENTS.md conventions, all production code changes must have corresponding tests in src/Web.Tests. Add a test that verifies the new 'Free shipping' highlight appears in the Highlights collection.

/// <summary>
/// Home-page content. Kept in one place so the demo's simple user stories (banner text,
Expand All @@ -12,6 +12,7 @@
// User Story: "Add a 'What's New' highlights section to the home page".
public static readonly IReadOnlyList<string> Highlights = new[]
{
"Free shipping on orders over 100",

Check failure on line 15 in src/Web/HomeContent.cs

View check run for this annotation

ai-sdlc-pr-review-agent / PR Review Agent

[HIGH] User-facing string violates American-English convention 

The string 'Free shipping on orders over 100' is missing a currency symbol. Per .github/copilot-instructions.md, user-facing strings under src/ must follow American-English conventions. Change to 'Free shipping on orders over $100' to properly format the monetary value.

Check warning on line 15 in src/Web/HomeContent.cs

View check run for this annotation

ai-sdlc-pr-review-agent / PR Review Agent

[MEDIUM] Ambiguous monetary value lacks currency precision 

The promotional message doesn't specify currency (USD assumed but not stated). For clarity in user-facing copy, consider 'Free shipping on orders over $100 USD' or ensure the context makes the currency unambiguous elsewhere in the UI.

@ai-sdlc-pr-review-agent ai-sdlc-pr-review-agent Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIGH: User-facing string violates American-English convention

The string 'Free shipping on orders over 100' is missing a currency symbol. Per .github/copilot-instructions.md, user-facing strings under src/ must follow American-English conventions. Change to 'Free shipping on orders over $100' to properly format the monetary value.

@ai-sdlc-pr-review-agent ai-sdlc-pr-review-agent Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM: Ambiguous monetary value lacks currency precision

The promotional message doesn't specify currency (USD assumed but not stated). For clarity in user-facing copy, consider 'Free shipping on orders over $100 USD' or ensure the context makes the currency unambiguous elsewhere in the UI.

"See the latest updates in the What is New section",
"Migrated from Azure DevOps to GitHub with full history and pull requests",
"AI-assisted code review on every pull request",
Expand Down
Loading