Skip to content

fix(notifs): Default colors off #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(notifs): Default colors off #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e7cef
fix(notifs): Default colors off
Oct 9, 2023
72e3b9b
fix: update tests
afonsojramos Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/context/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ describe('context/App.tsx', () => {
participating: true,
playSound: true,
showNotifications: true,
colors: true,
colors: false,
},
);
});
Expand Down Expand Up @@ -302,7 +302,7 @@ describe('context/App.tsx', () => {
participating: false,
playSound: true,
showNotifications: true,
colors: true,
colors: false,
},
);
});
Expand Down
2 changes: 1 addition & 1 deletion src/context/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const defaultSettings: SettingsState = {
markOnClick: false,
openAtStartup: false,
appearance: Appearance.SYSTEM,
colors: true,
colors: false,
};

interface AppContextState {
Expand Down
2 changes: 1 addition & 1 deletion src/routes/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const SettingsRoute: React.FC = () => {

<FieldCheckbox
name="colors"
label="Use colors to indicate state"
label="Use GitHub-like state colors (requires re-auth)"
checked={settings.colors}
onChange={(evt) => updateSetting('colors', evt.target.checked)}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/__snapshots__/Settings.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ exports[`routes/Settings.tsx should render itself & its children 1`] = `
className="font-medium text-gray-700 dark:text-gray-200"
htmlFor="colors"
>
Use colors to indicate state
Use GitHub-like state colors (requires re-auth)
</label>
</div>
</div>
Expand Down